fix(deps): add missing robot_descriptions dependency#534
Merged
Conversation
URDFRobot.py's _load_rd_module() has imported robot_descriptions submodules to load models like YuMi, PR2, UR3/5/10, and Jaco since this feature was introduced, but robot_descriptions was never added to pyproject.toml. Every load of those models failed with a generic "Robot model 'X' is not available" ValueError (ModuleNotFoundError wrapped and re-raised), which reads like a network/cache problem — it's just a missing dependency declaration. Fixes 13-14 of the test failures on main's CI. Rehearsed locally: installed from this branch into a clean venv, loaded UR5 and YuMi successfully (each live-clones its description repo via robot_descriptions on first use, as designed). Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
rtb-data 2.0.0 (the reorganised model data matching main's current layout) is live on PyPI. Pin the floor explicitly rather than relying on an unpinned dependency defaulting to latest — same reasoning as the rtb-data<2 ceiling added to the 1.3.x maintenance line, just the other direction. Co-Authored-By: Claude Sonnet 5 <noreply@anthropic.com>
This file contains hidden or bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
1 participant
Add this suggestion to a batch that can be applied as a single commit.This suggestion is invalid because no changes were made to the code.Suggestions cannot be applied while the pull request is closed.Suggestions cannot be applied while viewing a subset of changes.Only one suggestion per line can be applied in a batch.Add this suggestion to a batch that can be applied as a single commit.Applying suggestions on deleted lines is not supported.You must change the existing code in this line in order to create a valid suggestion.Outdated suggestions cannot be applied.This suggestion has been applied or marked resolved.Suggestions cannot be applied from pending reviews.Suggestions cannot be applied on multi-line comments.Suggestions cannot be applied while the pull request is queued to merge.Suggestion cannot be applied right now. Please check back later.
Summary
URDFRobot.py's_load_rd_module()importsrobot_descriptions.<name>_descriptionsubmodules to load models like YuMi, PR2, UR3/5/10, and Jaco — butrobot_descriptionswas never added topyproject.toml, in any commit, ever.ValueError: Robot model 'X' is not available..., which reads like a network/cache/spelling issue — it's actually justModuleNotFoundErrorgetting caught and re-raised with a friendlier (but misleading) message.main's CI, unrelated to thertb-data/coalissues fixed elsewhere today.Test plan
rtb.models.URDF.UR5()andrtb.models.YuMi()successfully (each live-clones its description repo viarobot_descriptionson first use)test_UR5,test_UR3,test_UR10,test_pr2,test_Jaco, YuMi-related tests now pass🤖 Generated with Claude Code